cleanup redundant code in MultiControlledX, use MultiControlledPauli
#1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anurudhp
force-pushed
the
2024/07/deprecate-mcx
branch
from
81f33c3 to
5c1e62c
Compare
|
In the linked issue, it's proposed to beef up MultiControlledPauli into a MultiControlledU and (then?) do the migration. How much extra effort would it be to do it in this direction? It's a shame to get rid of a readable, qualtran-native decomposition. |
|
That should be easy, I can do that first |
|
handled in #1155 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially addresses #1131